Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix warning regarding ABC import from collections #274

Merged
merged 1 commit into from
Sep 25, 2020
Merged

chore: Fix warning regarding ABC import from collections #274

merged 1 commit into from
Sep 25, 2020

Conversation

tirkarthi
Copy link
Contributor

Similar to 19ce468

@codecov
Copy link

codecov bot commented Sep 11, 2020

Codecov Report

Merging #274 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #274   +/-   ##
=======================================
  Coverage   73.63%   73.63%           
=======================================
  Files          68       68           
  Lines        2966     2966           
  Branches      321      321           
=======================================
  Hits         2184     2184           
  Misses        720      720           
  Partials       62       62           
Impacted Files Coverage Δ
spidermon/core/suites.py 80.55% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0bf02a...d4c6a85. Read the comment docs.

@Gallaecio
Copy link
Member

Nice catch!

@rennerocha rennerocha changed the title Fix warning regarding ABC import from collections chore: Fix warning regarding ABC import from collections Sep 25, 2020
@rennerocha rennerocha merged commit 3ec3a95 into scrapinghub:master Sep 25, 2020
@rennerocha rennerocha added this to the 1.14.0 milestone Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants