Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: How-To Guide - Adding required fields coverage validation #247

Merged
merged 8 commits into from
May 6, 2020
Merged

docs: How-To Guide - Adding required fields coverage validation #247

merged 8 commits into from
May 6, 2020

Conversation

rennerocha
Copy link
Collaborator

This PR includes a how-to guide explaining how to use ValidationMonitorMixin together with the methods check_missing_required_fields_percent and check_missing_required_fields to validate minimum coverage of item fields considered as required.

@codecov
Copy link

codecov bot commented May 5, 2020

Codecov Report

Merging #247 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #247   +/-   ##
=======================================
  Coverage   71.65%   71.65%           
=======================================
  Files          67       67           
  Lines        2759     2759           
  Branches      309      309           
=======================================
  Hits         1977     1977           
  Misses        718      718           
  Partials       64       64           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9e4dd6...98a015f. Read the comment docs.

Copy link
Member

@Gallaecio Gallaecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great content!!!

@rennerocha rennerocha added this to the 1.12.1 milestone May 6, 2020
@rennerocha rennerocha merged commit e379613 into scrapinghub:master May 6, 2020
@rennerocha rennerocha deleted the docs-required-fields-coverage-validation branch May 6, 2020 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants