Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VCS pip line entry in test suite #453

Merged
merged 7 commits into from
Mar 5, 2025

Conversation

wkunert
Copy link
Contributor

@wkunert wkunert commented Mar 3, 2025

Since pipenv version 2024.3.0, an additional whitespace character is placed between the package name and the @ character (see pypa/pipenv#6282).

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.44%. Comparing base (6253fb8) to head (458b7d2).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #453   +/-   ##
=======================================
  Coverage   89.44%   89.44%           
=======================================
  Files          34       34           
  Lines        2406     2406           
=======================================
  Hits         2152     2152           
  Misses        254      254           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gallaecio Gallaecio requested review from kmike, wRAR and elacuesta March 5, 2025 07:12
@Gallaecio Gallaecio merged commit ee000f1 into scrapinghub:master Mar 5, 2025
31 checks passed
@Gallaecio
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants