Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.10 support #415

Merged
merged 4 commits into from
Mar 10, 2022
Merged

Python 3.10 support #415

merged 4 commits into from
Mar 10, 2022

Conversation

elacuesta
Copy link
Member

@elacuesta elacuesta commented Mar 10, 2022

Closes #412

@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #415 (c7375ed) into master (1c661ba) will increase coverage by 0.04%.
The diff coverage is n/a.

❗ Current head c7375ed differs from pull request most recent head 2d38b47. Consider uploading reports for the commit 2d38b47 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #415      +/-   ##
==========================================
+ Coverage   89.48%   89.52%   +0.04%     
==========================================
  Files          34       34              
  Lines        2415     2415              
==========================================
+ Hits         2161     2162       +1     
+ Misses        254      253       -1     
Impacted Files Coverage Δ
shub/image/deploy.py 95.10% <0.00%> (+0.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c661ba...2d38b47. Read the comment docs.

@elacuesta elacuesta requested review from ejulio and Gallaecio March 10, 2022 18:36
@@ -19,6 +19,7 @@ deps =
pyinstaller==4.0
pytest
packaging==20.4
setuptools==59.8.0 # https://github.com/pypa/setuptools/issues/3089
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream seems to be looking for a reproducible example for this bug. Any chance you can work one out? I fear they may close the issue without addressing it otherwise.

@elacuesta elacuesta merged commit 8a386b1 into master Mar 10, 2022
@elacuesta elacuesta deleted the py310-compatibility branch March 10, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Python 3.10
2 participants