Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of the deprecated binary parameter of the Python item exporter #71

Merged
merged 2 commits into from
Sep 15, 2023

Conversation

Gallaecio
Copy link
Member

Needed for the next Scrapy version due to scrapy/scrapy#6007.

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (a55cc06) 95.53% compared to head (1457278) 95.54%.

❗ Current head 1457278 differs from pull request most recent head c75f5e4. Consider uploading reports for the commit c75f5e4 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #71   +/-   ##
=======================================
  Coverage   95.53%   95.54%           
=======================================
  Files          14       14           
  Lines         739      740    +1     
=======================================
+ Hits          706      707    +1     
  Misses         33       33           
Files Changed Coverage Δ
sh_scrapy/crawl.py 87.14% <100.00%> (+0.28%) ⬆️
sh_scrapy/extension.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elacuesta elacuesta merged commit 6f7adf5 into scrapinghub:master Sep 15, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants