test: skip test if in FreeBSD jail

Test test-net-socket-local-address is flaky in FreeBSD jail but robust otherwise. Fixes: nodejs#2475 PR-URL: nodejs#3995 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
scovetta · Apr 2, 2016 · 56efb3d · 56efb3d
1 parent d7b199d
commit 56efb3d
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 8 deletions.
diff --git a/test/parallel/parallel.status b/test/parallel/parallel.status
@@ -19,4 +19,3 @@ test-child-process-exit-code      : PASS,FLAKY
 [$system==solaris] # Also applies to SmartOS
 
 [$system==freebsd]
-test-net-socket-local-address     : PASS,FLAKY
diff --git a/test/parallel/test-net-socket-local-address.js b/test/parallel/test-net-socket-local-address.js
@@ -1,24 +1,30 @@
 'use strict';
-var common = require('../common');
-var assert = require('assert');
-var net = require('net');
+const common = require('../common');
+const assert = require('assert');
+const net = require('net');
+
+// skip test in FreeBSD jails
+if (common.inFreeBSDJail) {
+  console.log('1..0 # Skipped: In a FreeBSD jail');
+  return;
+}
 
 var conns = 0;
 var clientLocalPorts = [];
 var serverRemotePorts = [];
 
-var server = net.createServer(function(socket) {
+const server = net.createServer(function(socket) {
   serverRemotePorts.push(socket.remotePort);
   conns++;
 });
 
-var client = new net.Socket();
+const client = new net.Socket();
 
-server.on('close', function() {
+server.on('close', common.mustCall(function() {
   assert.deepEqual(clientLocalPorts, serverRemotePorts,
                    'client and server should agree on the ports used');
   assert.equal(2, conns);
-});
+}));
 
 server.listen(common.PORT, common.localhostIPv4, testConnect);