This repository has been archived by the owner on Dec 6, 2023. It is now read-only.
fix: post channel reminders as custom message type #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the "@channel" and "@here" keywords not triggering mentions. By default, bot users are not allowed to trigger channel mentions. However, if the message type is not the default, this check is bypassed. Fix scottleedavis#204
|
@hanzei I strongly recommend you actually try the test case from the issue you've just auto-closed. I think you'll find it does not solve the issue at all, and @kemenaran should probably have corrected his commit message. |
|
awaiting response from mm team regarding #195 (comment) before movement on this issue |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the "@channel" and "@here" keywords not triggering mentions.
By default, bot users are not allowed to trigger channel mentions. However, if the message type is not the default, this check is bypassed.
This was discussed with the mattermost-server folks, and it seems an approved workaround for this issue.
Fix #204