Skip to content
This repository has been archived by the owner on Dec 6, 2023. It is now read-only.

WIP Issue 73 #137

Closed
wants to merge 40 commits into from
Closed

WIP Issue 73 #137

wants to merge 40 commits into from

Conversation

scottleedavis
Copy link
Owner

Issue #73

Adds post dropdown menu + submenu for scheduling

@codecov
Copy link

codecov bot commented Jul 30, 2019

Codecov Report

Merging #137 into master will increase coverage by 2.94%.
The diff coverage is 78.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
+ Coverage   66.45%   69.39%   +2.94%     
==========================================
  Files          12       12              
  Lines        3139     3333     +194     
==========================================
+ Hits         2086     2313     +227     
+ Misses        816      780      -36     
- Partials      237      240       +3
Impacted Files Coverage Δ
server/activate.go 65.3% <ø> (+1.3%) ⬆️
server/plugin.go 100% <ø> (ø) ⬆️
server/http.go 73.78% <70%> (-0.99%) ⬇️
server/reminder.go 73.01% <89.88%> (+3.91%) ⬆️
server/occurrence.go 61.9% <0%> (+0.12%) ⬆️
server/list.go 67.57% <0%> (+16.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55d786e...b634bc7. Read the comment docs.

@scottleedavis
Copy link
Owner Author

Screen Shot 2019-07-30 at 12 11 52 PM

@andrey-yantsen
Copy link

Hey @scottleedavis! Few days ago v5.18 was released... any chance you can continue with this pull request?

@frcho
Copy link

frcho commented Apr 27, 2020

Hey @scottleedavis! Any chance you can continue with this pull request?

@scottleedavis
Copy link
Owner Author

@hanzei @kaakaa would either of you be able to pick up and improve what I started please?

@scottleedavis
Copy link
Owner Author

@frcho I am not able to contribute currently. i did contribute the submenu functionality needed in MM-webapp
mattermost/mattermost-webapp#3357

@scottleedavis
Copy link
Owner Author

I will gift a $50 amazon gift card to the first person who completes this PR. And some Mattermost stickers.
IMG_0645 copy

@scottleedavis scottleedavis added Help Wanted Community help wanted Type/Enhancement New feature or improvement of existing feature labels May 10, 2020
@scottleedavis scottleedavis added this to the 0.4.5 milestone May 10, 2020
@scottleedavis scottleedavis linked an issue May 10, 2020 that may be closed by this pull request
@hanzei hanzei removed their request for review May 29, 2020 05:34
@zifeo
Copy link

zifeo commented Jun 22, 2020

@scottleedavis awesome job! Do you have some news when this might be merged? That would be a huge step for people migrating onto Mattermost.

@benbernard
Copy link

Hey @scottleedavis I see you're asking for help on this issue, what is required to get it across the line? Some updates / tests passing or.... ?

I'd love to help, as I love this feature in slack

@kaakaa
Copy link

kaakaa commented Jul 11, 2020

Hi @benbernard
I took a look into this PR, and I think this feature could be made to work with a few more tweaks (e.g.: my work).
However, while I was working on this, I found a CSS issue in the Mattermost codebase, so I think we'll have to fix it before this. (It's difficult for me due to my little knowledge about css...)
mattermost/mattermost-plugin-demo#101

@hanzei hanzei modified the milestones: 0.4.5, 0.5.0 Sep 7, 2021
@scottleedavis scottleedavis changed the title Issue 73 WIP Issue 73 Mar 14, 2023
@scottleedavis scottleedavis removed Help Wanted Community help wanted Type/Enhancement New feature or improvement of existing feature labels Mar 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add webapp feature for reminders from post 'more actions' ellipsis
7 participants