Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove -svc suffix in Service name for more consistency #33

Closed
wants to merge 2 commits into from

Conversation

mathieu-benoit
Copy link
Contributor

@mathieu-benoit mathieu-benoit commented Sep 6, 2024

Remove -svc suffix in Service name for more consistency with Deployment name. Common pattern/naming out there.

Context, with this:

apiVersion: score.dev/v1b1
metadata:
  name: store-front
containers:
  store-front:
    image: .
    variables:
      VUE_APP_ORDER_SERVICE_URL: "http://${resources.order-service.name}:3000/"
resources:
  order-service:
    type: service

And this:

- uri: template://service-provisioners/static-service
  type: service
  init: |
    name: {{ splitList "." .Id | last }}
  outputs: |
    {{ $w := (index .WorkloadServices .Init.name) }}
    name: {{ $w.ServiceName | quote }}

@mathieu-benoit mathieu-benoit changed the title Remove -svc suffix in Service name for more consistency Remove -svc suffix in Service name for more consistency Sep 6, 2024
@mathieu-benoit mathieu-benoit marked this pull request as draft September 6, 2024 12:11
@mathieu-benoit mathieu-benoit marked this pull request as draft September 6, 2024 12:11
@mathieu-benoit
Copy link
Contributor Author

Closing to implement this in there #34 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant