Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added amqp(rabbitmq) default provisioner to score-k8s #28

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

Gkemhcs
Copy link
Contributor

@Gkemhcs Gkemhcs commented Sep 3, 2024

This PR adds the RabbitMQ(amqp) provisioner to the default provisioners of score-k8s . Fixes #11

This was tested with a score file that looks like:

apiVersion: score.dev/v1b1
metadata:
  name: pika-python-client
containers:
   pika_client:
      image: python
      variables:
        amqp_connection_string : ${resources.amqp1.connection}
resources:
  amqp1:
    type: amqp
    
   
      

@astromechza
Copy link
Member

@Gkemhcs Do you have an example of the output running in a k8s cluster?

@astromechza
Copy link
Member

And once you've signed the DCO and signed your commit, the checks will pass :)

Signed-off-by: Gkemhcs <[email protected]>

* enhancement: added rabbitmq(amqp) as default provisoner to score-k8s
Signed-off-by: Gkemhcs <[email protected]>
@Gkemhcs
Copy link
Contributor Author

Gkemhcs commented Sep 4, 2024

@astromechza

Here is the sample score workload for k8s

apiVersion: score.dev/v1b1
metadata:
  name: amqp-demo
containers:
   nginx:
      image: nginx
      variables:
        AMQP_CONNECTION_URL : ${resources.amqp1.connection}
resources:
  amqp1:
    type: amqp

and resources it has deployed into the cluster along with pvc ,pv is in below snapshot

image

and logs of rabbitmq statefulset pod

image

here is output you asked for .

@Gkemhcs
Copy link
Contributor Author

Gkemhcs commented Sep 5, 2024

@astromechza ,As you instructed i have removed connection and management port from outputs of amqp provisioner

@astromechza astromechza merged commit 6803240 into score-spec:main Sep 5, 2024
3 checks passed
@mathieu-benoit
Copy link
Contributor

Thanks @Gkemhcs for you contribution! JFYI: this was one of the last pieces in order to have this sample apps working successfully and by default with both score-compose and score-k8s: https://medium.com/@mabenoit/what-if-the-azure-samples-aks-store-demo-was-using-score-655c55f1c3dd. Thanks!

@Gkemhcs
Copy link
Contributor Author

Gkemhcs commented Sep 15, 2024

You're welcome! I am glad that my first contribution helped community.
Looking forward to contribute some more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] Add amqp (rabbitmq) in the default provisioners
3 participants