-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added amqp(rabbitmq) default provisioner to score-k8s #28
Conversation
@Gkemhcs Do you have an example of the output running in a k8s cluster? |
And once you've signed the DCO and signed your commit, the checks will pass :) |
Signed-off-by: Gkemhcs <[email protected]> * enhancement: added rabbitmq(amqp) as default provisoner to score-k8s Signed-off-by: Gkemhcs <[email protected]>
97e4839
to
a7f0ef8
Compare
Here is the sample score workload for k8s apiVersion: score.dev/v1b1
metadata:
name: amqp-demo
containers:
nginx:
image: nginx
variables:
AMQP_CONNECTION_URL : ${resources.amqp1.connection}
resources:
amqp1:
type: amqp and resources it has deployed into the cluster along with pvc ,pv is in below snapshot and logs of rabbitmq statefulset pod here is output you asked for . |
Signed-off-by: Gkemhcs <[email protected]>
@astromechza ,As you instructed i have removed connection and management port from outputs of amqp provisioner |
Thanks @Gkemhcs for you contribution! JFYI: this was one of the last pieces in order to have this sample apps working successfully and by default with both |
You're welcome! I am glad that my first contribution helped community. |
This PR adds the RabbitMQ(amqp) provisioner to the default provisioners of score-k8s . Fixes #11
This was tested with a score file that looks like: