Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature request] Add mongodb in the default provisioners #23

Merged
merged 5 commits into from
Aug 20, 2024
Merged

[feature request] Add mongodb in the default provisioners #23

merged 5 commits into from
Aug 20, 2024

Conversation

giesan
Copy link
Contributor

@giesan giesan commented Jul 18, 2024

This PR adds the MongoDB provisioner to the default provisioners. Fixes #12.

This was tested with a score file that looks like:

apiVersion: score.dev/v1b1
containers:
    main:
        image: stefanprodan/podinfo
metadata:
    name: example

resources:
    db:
        type: mongo

@astromechza
Copy link
Member

Thanks for the PR @giesan , sorry this took some time to get around to. Going to test it out now.

astromechza
astromechza approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@astromechza astromechza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @giesan !

@astromechza astromechza merged commit bbbdcdc into score-spec:main Aug 20, 2024
3 checks passed
@giesan giesan deleted the 12-add-mongodb-provisioner branch August 20, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astromechza astromechza astromechza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature request] Add mongodb in the default provisioners
2 participants
@giesan @astromechza