fix(convert): fixed panic in resource limits conversion (#15)

Signed-off-by: Ben Meier <[email protected]>
score-spec · May 30, 2024 · f2a3559 · f2a3559
1 parent e675f96
commit f2a3559
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/internal/convert/container_resources.go b/internal/convert/container_resources.go
@@ -30,6 +30,8 @@ func convertContainerResources(resources *scoretypes.ContainerResources) (coreV1
 			if err != nil {
 				return out, errors.Wrap(err, "requests: failed to convert")
 			}
+		}
+		if resources.Limits != nil {
 			out.Limits, err = buildResourceList(resources.Limits)
 			if err != nil {
 				return out, errors.Wrap(err, "limits: failed to convert")

diff --git a/internal/convert/container_resources_test.go b/internal/convert/container_resources_test.go
@@ -56,3 +56,17 @@ func Test_convertContainerResources_nominal(t *testing.T) {
 		},
 	}, rl)
 }
+
+func Test_convertContainerResources_partial(t *testing.T) {
+	rl, err := convertContainerResources(&scoretypes.ContainerResources{
+		Limits: &scoretypes.ResourcesLimits{
+			Memory: internal.Ref("20Mi"),
+		},
+	})
+	assert.NoError(t, err)
+	assert.Equal(t, coreV1.ResourceRequirements{
+		Limits: map[coreV1.ResourceName]resource.Quantity{
+			"memory": resource.MustParse("20Mi"),
+		},
+	}, rl)
+}