Unexclude CentOS 7 container for ruby 3.0

[jackorp]

Tested locally, works.

The only tests that are not passing are related to the rails-ex app. JFTR sclorg/rails-ex#134

[centos-ci]

Can one of the admins verify this patch?

[centos-ci]

Can one of the admins verify this patch?

[centos-ci]

Can one of the admins verify this patch?

[phracek]

[test][test-openshift][test-openshift-4]

[phracek]

@jackorp There are no network issues. We are using nexus. Please fix the test suites

[jackorp]

@jackorp There are no network issues. We are using nexus. Please fix the test suites

Not sure what nexus is or what is there to fix (as there were no new commits on the master branch). Could you please elaborate?

[phracek]

Not sure what nexus is or what is there to fix

Our private proxy.

What to fix?
Testing Farm - RHEL7

---> Cleaning up unused ruby gems ...
Running `bundle clean --verbose` with bundler 2.2.22
Frozen, using resolution from the lockfile
---> Starting asset compilation ...
[91mrake aborted!
ArgumentError: wrong number of arguments (given 3, expected 2)
[0m[91m/opt/app-root/src/bundle/ruby/3.0.0/gems/actionpack-5.1.7/lib/action_dispatch/middleware/static.rb:109:in `initialize'
/opt/app-root/src/bundle/ruby/3.0.0/gems/actionpack-5.1.7/lib/action_dispatch/middleware/stack.rb:35:in `new'
/opt/app-root/src/bundle/ruby/3.0.0/gems/actionpack-5.1.7/lib/action_dispatch/middleware/stack.rb:35:in `build'
/opt/app-root/src/bundle/ruby/3.0.0/gems/actionpack-5.1.7/lib/action_dispatch/middleware/stack.rb:99:in `block in build'
/opt/app-root/src/bundle/ruby/3.0.0/gems/actionpack-5.1.7/lib/action_dispatch/middleware/stack.rb:99:in `each'
/opt/app-root/src/bundle/ruby/3.0.0/gems/actionpack-5.1.7/lib/action_dispatch/middleware/stack.rb:99:in `inject'
/opt/app-root/src/bundle/ruby/3.0.0/gems/actionpack-5.1.7/lib/action_dispatch/middleware/stack.rb:99:in `build'
/opt/app-root/src/bundle/ruby/3.0.0/gems/railties-5.1.7/lib/rails/engine.rb:508:in `block in app'
/opt/app-root/src/bundle/ruby/3.0.0/gems/railties-5.1.7/lib/rails/engine.rb:504:in `synchronize'
/opt/app-root/src/bundle/ruby/3.0.0/gems/railties-5.1.7/lib/rails/engine.rb:504:in `app'
/opt/app-root/src/bundle/ruby/3.0.0/gems/railties-5.1.7/lib/rails/application/finisher.rb:45:in `block in <module:Finisher>'
/opt/app-root/src/bundle/ruby/3.0.0/gems/railties-5.1.7/lib/rails/initializable.rb:30:in `instance_exec'
/opt/app-root/src/bundle/ruby/3.0.0/gems/railties-5.1.7/lib/rails/initializable.rb:30:in `run'
/opt/app-root/src/bundle/ruby/3.0.0/gems/railties-5.1.7/lib/rails/initializable.rb:59:in `block in run_initializers'
/opt/app-root/src/bundle/ruby/3.0.0/gems/railties-5.1.7/lib/rails/initializable.rb:58:in `run_initializers'
/opt/app-root/src/bundle/ruby/3.0.0/gems/railties-5.1.7/lib/rails/application.rb:353:in `initialize!'
/opt/app-root/src/config/environment.rb:5:in `<top (required)>'
/opt/app-root/src/bundle/ruby/3.0.0/gems/railties-5.1.7/lib/rails/application.rb:329:in `require'
/opt/app-root/src/bundle/ruby/3.0.0/gems/railties-5.1.7/lib/rails/application.rb:329:in `require_environment!'
/opt/app-root/src/bundle/ruby/3.0.0/gems/railties-5.1.7/lib/rails/application.rb:445:in `block in run_tasks_blocks'
/opt/app-root/src/bundle/ruby/3.0.0/gems/sprockets-rails-3.2.2/lib/sprockets/rails/task.rb:61:in `block (2 levels) in define'
/opt/app-root/src/bundle/ruby/3.0.0/gems/rake-13.0.3/exe/rake:27:in `<top (required)>'
Tasks: TOP => environment
(See full trace by running task with --trace)
[0mThe command '/bin/sh -c /usr/libexec/s2i/assemble' returned a non-zero code: 1
+ echo 'ERROR: The image cannot be built from /tmp/sclorg/s2i-ruby-container/3.0/test/examples/from-dockerfile/Dockerfile.s2i and application https://github.com/sclorg/rails-ex.git.'

[pvalena]

Please note this is Ruby 3.0 compatibility related issue:

ArgumentError: wrong number of arguments (given 3, expected 2)

Rails version 5 (the test app) is incompatible with Ruby 3.0. The app needs to be upgraded to be able to work with newer Ruby. AFAIK @jackorp is actively working on this. Any updates?

[pkubatrh]

@jackorp gentle ping

[jackorp]

@jackorp gentle ping

We are getting closer to having it merged. There were some things to iron out with the new Rails version, but the newest changes look promising (log is for fedora, will have centos shortly): https://gist.github.com/jackorp/dc69f67f384c069b8ea3e84ce2e0bcfc .

JFTR tested with this version of rails app: pvalena/rails-ex#3

[pvalena]

I've merged the rails-ex PR which was blocking this AFAIR (first comment here).

[pvalena]

The CI failure seems to be infra-related to me:
error: unable to upgrade connection: container not found ("command-container")
Anyway, this PR does not introduce anything new.
LGTM.