Skip to content

Comments

Reorder tests in test suite#317

Merged
pvalena merged 1 commit intomasterfrom
pvalena-patch-1
Mar 19, 2021
Merged

Reorder tests in test suite#317
pvalena merged 1 commit intomasterfrom
pvalena-patch-1

Conversation

@pvalena
Copy link
Member

@pvalena pvalena commented Mar 7, 2021

to make the test suite more user-friendly.

Related: PR #316.

to make the test suite more user-friendly.

Related: PR #316.
@phracek
Copy link
Member

phracek commented Mar 8, 2021

[test]

@phracek
Copy link
Member

phracek commented Mar 8, 2021

The change itself looks good. But wait with merging. I will prepare an environment with sync into Fedora dist-git repository.
I WILL MERGE IT.

@phracek
Copy link
Member

phracek commented Mar 8, 2021

The CentOS test failed on run-conu

./test/run-conu: line 2: exec: pytest: not found

Fedora test failed:

00:55:10 + readarray -d @ -t git_url_parts
00:55:10 /root/sources/2.7/test/test-lib.sh: line 870: readarray: -d: invalid option
00:55:10 readarray: usage: readarray [-n count] [-O origin] [-s count] [-t] [-u fd] [-C callback] [-c quantum] [array]

This should be fixed by sclorg/container-common-scripts#191
Another bug:

0:56:44 LoadError: cannot load such file -- bundler/setup
00:56:44 �[0m�[91m/opt/app-root/src/config/boot.rb:3:in `require'
00:56:44 /opt/app-root/src/config/boot.rb:3:in `<top (required)>'
00:56:44 /opt/app-root/src/config/application.rb:1:in `require_relative'
00:56:44 /opt/app-root/src/config/application.rb:1:in `<top (required)>'
00:56:44 /opt/app-root/src/Rakefile:4:in `require_relative'
00:56:44 /opt/app-root/src/Rakefile:4:in `<top (required)>'
00:56:44 /opt/app-root/src/bundle/ruby/2.7.0/gems/rake-13.0.1/exe/rake:27:in `<top (required)>'
00:56:44 /usr/share/gems/gems/bundler-2.1.4/lib/bundler/cli/exec.rb:63:in `load'
00:56:44 /usr/share/gems/gems/bundler-2.1.4/lib/bundler/cli/exec.rb:63:in `kernel_load'
00:56:44 /usr/share/gems/gems/bundler-2.1.4/lib/bundler/cli/exec.rb:28:in `run'
00:56:44 /usr/share/gems/gems/bundler-2.1.4/lib/bundler/cli.rb:476:in `exec'
00:56:44 /usr/share/gems/gems/bundler-2.1.4/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
00:56:44 /usr/share/gems/gems/bundler-2.1.4/lib/bundler/vendor/thor/lib/thor/invocation.rb:127:in `invoke_command'
00:56:44 /usr/share/gems/gems/bundler-2.1.4/lib/bundler/vendor/thor/lib/thor.rb:399:in `dispatch'
00:56:44 /usr/share/gems/gems/bundler-2.1.4/lib/bundler/cli.rb:30:in `dispatch'
00:56:44 /usr/share/gems/gems/bundler-2.1.4/lib/bundler/vendor/thor/lib/thor/base.rb:476:in `start'
00:56:44 /usr/share/gems/gems/bundler-2.1.4/lib/bundler/cli.rb:24:in `start'
00:56:44 /usr/share/gems/gems/bundler-2.1.4/libexec/bundle:46:in `block in <top (required)>'
00:56:44 /usr/share/gems/gems/bundler-2.1.4/lib/bundler/friendly_errors.rb:123:in `with_friendly_errors'
00:56:44 /usr/share/gems/gems/bundler-2.1.4/libexec/bundle:34:in `<top (required)>'
00:56:44 /opt/app-root/src/bin/bundle:3:in `load'
00:56:44 /opt/app-root/src/bin/bundle:3:in `<main>'

This is already reported here: #312

@pvalena
Copy link
Member Author

pvalena commented Mar 10, 2021

Yes, the failures are not related to this. Also this should not break anything [tested localy].

@phracek
Copy link
Member

phracek commented Mar 18, 2021

Conu is disabled and not executed. Let's try test.

[test]

@phracek
Copy link
Member

phracek commented Mar 19, 2021

[test]

Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the Fedora test, we have an issue here #312 . The rest is OK.
Conu was removed. As soon as we have approval, we can merge it @pvalena .

@pvalena pvalena merged commit ecf874e into master Mar 19, 2021
@zmiklank zmiklank deleted the pvalena-patch-1 branch November 23, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants