PostgreSQL settings. #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We added a `set -u` in previous commit which causes a "unbound variable" failure if some environment variables weren't defined.
This will allow us to run the image easily with just postgres and other parameters, which is generally useful for debugging/testing/experimenting.
Contributor
Author
|
[test] |
Contributor
|
LGTM |
mnagy
force-pushed
the
config_customization
branch
from
7627361 to
721df10
Compare
Contributor
Author
|
Moved configuration into it's own contrib file as per @mfojtik's offline comments. PTAL |
Separate initdb-generated config and our custom configuration that is recreated on each container restart, according to the provided environment variables, similarly to the MySQL image. Added two settings, both from OpenShift v2 PostgreSQL cartridge: * POSTGRESQL_MAX_CONNECTIONS * POSTGRESQL_SHARED_BUFFERS
mnagy
force-pushed
the
config_customization
branch
from
721df10 to
8c27b59
Compare
Contributor
Author
|
..and added forgotten documentation to readme.. |
Contributor
Author
|
@mfojtik can you PTAL? |
Contributor
There was a problem hiding this comment.
Pls say here that this will be appended to the postgresql.conf, allowing users to modify it as they want.
Contributor
|
@mnagy one small nit, but my LGTM is still valid ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is analogous to sclorg/mysql-container#25
I only found two settings in v2 PostgreSQL.