Various changes to sync-up with PostgreSQL image #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnagy
force-pushed
the
additional_postgres_sync
branch
from
365ab8c to
e1eebe8
Compare
Contributor
There was a problem hiding this comment.
maybe explain the reasoning in docs or in comment
mnagy
force-pushed
the
additional_postgres_sync
branch
from
e1eebe8 to
a03dbda
Compare
Contributor
Author
|
@mfojtik comments addressed. PTAL |
Contributor
|
LGTM. |
Collaborator
There was a problem hiding this comment.
so does this work if i just docker exec into a running container with /bin/sh?
Contributor
Author
There was a problem hiding this comment.
nope, but will work with interactive bash shell.
Collaborator
There was a problem hiding this comment.
image_creation seems like the wrong name for this... do you mean db creation?
mnagy
force-pushed
the
additional_postgres_sync
branch
from
a03dbda to
f85aa67
Compare
* Put DB volume into /var/lib/mysql/data, add SCL .bashrc * Move DB volume into /var/lib/mysql/data * Add SCL enablement into /var/lib/mysql/.bashr so we can now run the arbitrary commands in the image without needing to override the entrypoint * Test DB and user names for maximum allowed length * Better error messages for invalid env vars * Tests for the above
mnagy
force-pushed
the
additional_postgres_sync
branch
from
f85aa67 to
5b6ebf8
Compare
Collaborator
|
lgtm. |
mnagy
added a commit
that referenced
this pull request
Mar 23, 2015
Various changes to sync-up with PostgreSQL image
hhorak
pushed a commit
to hhorak/mysql-container
that referenced
this pull request
May 23, 2018
update squash tool version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds few improvements that were novel in the PostgreSQL image.
arbitrary commands in the image without needing to override the
entrypoint