-
-
Notifications
You must be signed in to change notification settings - Fork 5
BUG: run tests in a tempdir, copy needed local files #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cfdd31f to
ccb3eb2
Compare
|
Two things I do not understand ATM:
|
ccb3eb2 to
d5b567f
Compare
44b3199 to
20594e1
Compare
I believe the However, the local files are typically located in the same directory as the module referencing them so the values should just be the names of the files: dt_config.local_resources = {'scpdt.tests.local_file_cases.local_files':
['local_file.txt'],
'scpdt.tests.local_file_cases.sio':
['octave_a.mat']
}I pulled this branch locally and this slight change seems to work. |
|
Could you send your changes as a PR for the CI to run? |
That seems to have done the trick: #127 |
|
Yup sure, if that's more convenient. |
Actually, I'll cherry-pick it and squash my debug commits. |
😅 too late |
0bed0d4 to
19f3534
Compare
|
OK :-). |
|
Merging in. Thank you Sheila for the fix! |
When ready, will fix gh-101
(edited)