BLD: ensure all static libraries use hidden visibility #20477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgommers
added
the
Build issues
rgommers
requested review from
andyfaff,
ev-br,
perimosocordiae,
person142 and
steppi
as code owners
github-actions
bot
added
scipy.stats
scipy.special
scipy.sparse.linalg
scipy.sparse
scipy.optimize
scipy.interpolate
scipy.integrate
scipy.odr
Meson
lucascolley
requested review from
thalassemia
and removed request for
andyfaff,
ev-br,
perimosocordiae,
person142 and
steppi
thalassemia
reviewed
Apr 14, 2024
It can; I left that out on purpose because those static libraries are being removed in gh-19255, so touching them here will only yield a merge conflict. |
|
I re-ran the one CI job that timed out on Cirrus, that was a flake - all green now. |
This avoids exporting symbols from static libraries in the extension modules, which was happening for compilers that support GNU visibility attributes but not the linker script (e.g., Clang on macOS).
thalassemia
force-pushed
the
staticlibs-hiddenvisibility
branch
from
18bd415 to
be0a047
Compare
thalassemia
approved these changes
Apr 15, 2024
|
Followed up with a similar change to |
rgommers
added a commit
to rgommers/scipy
that referenced
this pull request
Jun 7, 2024
This is a follow-up to scipygh-20477, where HiGHS wasn't touched on purpose to avoid a merge conflict in another PR. Closes scipygh-20256
rgommers
added a commit
to rgommers/scipy
that referenced
this pull request
Jun 7, 2024
This is a follow-up to scipygh-20477, where HiGHS wasn't touched on purpose to avoid a merge conflict in another PR. Minor useful side benefit: it shrinks the size of `_highs_wrapper.so` by 0.4% Closes scipygh-20256
tylerjereddy
pushed a commit
to tylerjereddy/scipy
that referenced
this pull request
Jun 10, 2024
This is a follow-up to scipygh-20477, where HiGHS wasn't touched on purpose to avoid a merge conflict in another PR. Minor useful side benefit: it shrinks the size of `_highs_wrapper.so` by 0.4% Closes scipygh-20256
tylerjereddy
pushed a commit
to tylerjereddy/scipy
that referenced
this pull request
Jun 10, 2024
This is a follow-up to scipygh-20477, where HiGHS wasn't touched on purpose to avoid a merge conflict in another PR. Minor useful side benefit: it shrinks the size of `_highs_wrapper.so` by 0.4% Closes scipygh-20256 [ci skip] [skip ci] [skip circle]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids exporting symbols from static libraries in the extension modules, which was happening for compilers that support GNU visibility attributes but not the linker script (e.g., Clang on macOS).
The gain in binary size for a wheel on macOS is only 0.06%, but every little bit helps.