Fix bit checking when sizeof(mp_limb_t) != sizeof(unsigned long) #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix! Would this alternatively be fixed by changing |
|
I guess 1ull can work as well, but it's less clean when mp_limb_t == long and sizeof(long) == 32. 1ull is 64 bit and the bit shift result will be truncated from 64 bit to 32 bit. That will probably work, but the extra conversion is unnecessary. |
ValarDragon
previously approved these changes
Oct 20, 2020
|
Not sure why changing the base branch added so many commits, I'll just merge to staging, and then cherry-pick this onto develop. Thanks! |
ValarDragon
pushed a commit
that referenced
this pull request
Oct 20, 2020
ValarDragon
pushed a commit
that referenced
this pull request
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For instance, on Windows long is 32 bit, while long long is 64 bit