-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the Windows MSVC build #115
Conversation
…ally underlying u32. This fixes the build on Windows MSVC, where enums are represented as i32 instead.
* The file itself is moved into an ignored data directory, so it never shows up in VCS. * The model is dropped before deleting the file, so it can be deleted (this is important on Windows).
Codecov Report
@@ Coverage Diff @@
## main #115 +/- ##
==========================================
+ Coverage 74.61% 74.96% +0.35%
==========================================
Files 13 13
Lines 1729 1725 -4
==========================================
+ Hits 1290 1293 +3
+ Misses 439 432 -7
|
Thanks a lot for your contribution! could you please also update the |
I added a new version (0.1.5) of |
I hope I added that to the right section of the changelog 😅 . |
Yeah, it's always a philosophical dilemma for me too 😄 Thanks again @KarelPeeters! |
Thanks for the quick merges! |
Fixes #114, also has some other small improvements.
Depends on scipopt/scip-sys#4 to actually fully build on windows, so maybe a version bump of the sys crate and a corresponding change in this
Cargo.toml
is necessary.