Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regex for file rm/ls #1029

Merged
merged 4 commits into from
Mar 9, 2022
Merged

Fix regex for file rm/ls #1029

merged 4 commits into from
Mar 9, 2022

Conversation

talavis
Copy link
Contributor

@talavis talavis commented Mar 9, 2022

Escape the folder name before adding using it in a regex. Avoids missinterpretation of e.g. [].

Reverts #1019 since that change did nothing except making the query a bit uglier in the mariadb log.

Closes #1018

  • Tests passing
  • Black formatting
  • [-] Migrations for any changes to the database schema
  • Rebase/merge the dev branch
  • Note in the CHANGELOG

@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #1029 (bd2fc37) into dev (3104aaa) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head bd2fc37 differs from pull request most recent head 418ad73. Consider uploading reports for the commit 418ad73 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1029      +/-   ##
==========================================
+ Coverage   87.59%   87.61%   +0.01%     
==========================================
  Files          27       27              
  Lines        2943     2946       +3     
==========================================
+ Hits         2578     2581       +3     
  Misses        365      365              
Impacted Files Coverage Δ
dds_web/api/files.py 83.98% <100.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3104aaa...418ad73. Read the comment docs.

Copy link
Member

@i-oden i-oden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried uploading and downloading, deleting and listing. The commands that I've tested works with both special characters and without

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deletion not happening
2 participants