-
Notifications
You must be signed in to change notification settings - Fork 214
Conversation
LGTM! |
@mblondel Don't you mind creating a new release? |
@fabianp took care of the releases so far. Maybe he can give you the rights if you're ok to take care of the release this time. |
I can trigger artifacts creation and prepare a GitHub release. One has to upload those files to PyPI. |
@fabianp Thank you so much! I see you've successfully pushed new tag ( https://github.com/scikit-learn-contrib/lightning/releases One remained thing is to make created release publicly available (it is Now it's marked as We can skip lightning/.github/workflows/main.yml Line 131 in 6e9afff
But I find it useful to make sure that everything is OK and write some release notes before making release publicly visible. Unfortunately, I see only archive with sources uploaded at PyPI. This PR adds compilation of wheel files for all platforms and actual Python versions (refer also to #182 (comment) and #182 (comment)). Could you please upload wheel files as well (they are attached to the release)? |
Gently ping @fabianp |
is there a way that I can download all those files at once?
…On Wed, Jun 23, 2021 at 9:51 AM Nikita Titov ***@***.***> wrote:
Gently ping @fabianp <https://github.com/fabianp>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#184 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACDZB7KCS37QJ55FB23A2TTUHRFHANCNFSM46IRSU4Q>
.
|
@fabianp I don't know any way to do that. Seems there is no easy way: https://stackoverflow.com/a/35280061 (parse JSON file with links). |
thanks, should be done now
…On Sat, Jun 26, 2021 at 1:57 PM Nikita Titov ***@***.***> wrote:
@fabianp <https://github.com/fabianp> I don't know any way to do that.
Seems there is no *easy* way: https://stackoverflow.com/a/35280061 (parse
JSON file with links).
Just download them one by one.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#184 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACDZB77DHFSH2CIWRPM4ETTUYIJ3ANCNFSM46IRSU4Q>
.
|
@fabianp Thank you so much!
|
Wheels for all platforms and source archive will be automatically uploaded to Releases tab with each tagged commit.
For example please refer to https://github.com/StrikerRUS/lightning/releases/tag/untagged-a19e7c8d925f0295f2b6.
Unfortunately, neither
manylinux2010
normanylinux1
containers cannot be used due to the following restriction of Node.js: actions/runner#337. But I thinkmanylinux2014
is better than nothing. Moreover, CentOS 6 and CentOS 5 on which those containers are based have already reached their EOL.https://github.com/pypa/manylinux