Skip to content
This repository has been archived by the owner on Dec 6, 2023. It is now read-only.

Build artifacts at GitHub Actions #184

Merged
merged 2 commits into from
Jun 12, 2021
Merged

Build artifacts at GitHub Actions #184

merged 2 commits into from
Jun 12, 2021

Conversation

StrikerRUS
Copy link
Contributor

Wheels for all platforms and source archive will be automatically uploaded to Releases tab with each tagged commit.

For example please refer to https://github.com/StrikerRUS/lightning/releases/tag/untagged-a19e7c8d925f0295f2b6.

Unfortunately, neither manylinux2010 nor manylinux1 containers cannot be used due to the following restriction of Node.js: actions/runner#337. But I think manylinux2014 is better than nothing. Moreover, CentOS 6 and CentOS 5 on which those containers are based have already reached their EOL.
https://github.com/pypa/manylinux

@StrikerRUS StrikerRUS requested review from mblondel and vene June 7, 2021 21:57
@mblondel
Copy link
Member

mblondel commented Jun 9, 2021

LGTM!

@StrikerRUS StrikerRUS merged commit 471a141 into scikit-learn-contrib:master Jun 12, 2021
@StrikerRUS
Copy link
Contributor Author

@mblondel Don't you mind creating a new release?

@mblondel
Copy link
Member

@fabianp took care of the releases so far. Maybe he can give you the rights if you're ok to take care of the release this time.

@StrikerRUS
Copy link
Contributor Author

StrikerRUS commented Jun 15, 2021

I can trigger artifacts creation and prepare a GitHub release. One has to upload those files to PyPI.

@fabianp
Copy link
Member

fabianp commented Jun 15, 2021

@StrikerRUS
Copy link
Contributor Author

StrikerRUS commented Jun 16, 2021

@fabianp Thank you so much!

I see you've successfully pushed new tag (0.6.1) and GitHub Actions uploaded all artifacts as expected.

https://github.com/scikit-learn-contrib/lightning/releases

image

One remained thing is to make created release publicly available (it is Draft and visible only by users with write access to the repo). I've just done it by clicking Edit -> Publish release.

image

Now it's marked as Latest release and looks like the following:

image

We can skip Draft state of new releases by modifying this line


But I find it useful to make sure that everything is OK and write some release notes before making release publicly visible.

Unfortunately, I see only archive with sources uploaded at PyPI.
https://pypi.org/project/sklearn-contrib-lightning/0.6.1/#files

This PR adds compilation of wheel files for all platforms and actual Python versions (refer also to #182 (comment) and #182 (comment)). Could you please upload wheel files as well (they are attached to the release)?

image

@StrikerRUS
Copy link
Contributor Author

Gently ping @fabianp

@fabianp
Copy link
Member

fabianp commented Jun 25, 2021 via email

@StrikerRUS
Copy link
Contributor Author

@fabianp I don't know any way to do that. Seems there is no easy way: https://stackoverflow.com/a/35280061 (parse JSON file with links).
Just download them one by one.

@fabianp
Copy link
Member

fabianp commented Jun 29, 2021 via email

@StrikerRUS
Copy link
Contributor Author

@fabianp Thank you so much!
I checked on my Windows machine - it downloads wheel file correctly and estimators that depend on cpp code work fine.

#>pip install sklearn-contrib-lightning
Collecting sklearn-contrib-lightning
  Downloading sklearn_contrib_lightning-0.6.1-cp38-cp38-win_amd64.whl (646 kB)
     |████████████████████████████████| 646 kB 3.3 MB/s
Requirement already satisfied: numpy in d:\miniconda3\lib\site-packages (from sklearn-contrib-lightning) (1.20.1)
Requirement already satisfied: scikit-learn in d:\miniconda3\lib\site-packages (from sklearn-contrib-lightning) (0.24.1)
Requirement already satisfied: joblib in d:\miniconda3\lib\site-packages (from sklearn-contrib-lightning) (1.0.1)
Requirement already satisfied: scipy in d:\miniconda3\lib\site-packages (from sklearn-contrib-lightning) (1.6.2)
Requirement already satisfied: threadpoolctl>=2.0.0 in d:\miniconda3\lib\site-packages (from scikit-learn->sklearn-contrib-lightning) (2.1.0)
Installing collected packages: sklearn-contrib-lightning
Successfully installed sklearn-contrib-lightning-0.6.1

@StrikerRUS StrikerRUS mentioned this pull request Jan 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants