Skip to content

Conversation

@MatthewSZhang
Copy link
Collaborator

Checklist

  • Used a personal fork to propose changes
  • A reference to a related issue: FIX refine uses wrong stop criteria #183
  • A description of the changes: change the stop criteria from i < n_features to i < n_features_to_select

@MatthewSZhang MatthewSZhang self-assigned this Oct 16, 2025
@MatthewSZhang MatthewSZhang added the bug Something isn't working label Oct 16, 2025
@MatthewSZhang MatthewSZhang added this to the 0.4.2 milestone Oct 16, 2025
@MatthewSZhang MatthewSZhang linked an issue Oct 16, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (c2a8ca5) to head (1d9680e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #184   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          611       611           
=========================================
  Hits           611       611           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MatthewSZhang MatthewSZhang merged commit c1a4e43 into scikit-learn-contrib:main Oct 16, 2025
19 checks passed
@MatthewSZhang MatthewSZhang deleted the refine-stop branch October 16, 2025 03:06
github-actions bot added a commit that referenced this pull request Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FIX refine uses wrong stop criteria

1 participant