Skip to content

Conversation

@nsmith-
Copy link
Member

@nsmith- nsmith- commented Mar 1, 2024

Report type is now

type: 7 * {
    call_time: ?unknown,
    duration: float64,
    performance_counters: {
        num_requested_bytes: int64,
        num_requests: int64,
        num_requested_chunks: int64
    },
    args: var * string,
    kwargs: var * unknown,
    exception: ?unknown,
    message: ?unknown,
    fqdn: ?unknown,
    hostname: ?unknown
}

@nsmith- nsmith- changed the title Record source performance counters in uproot.dask report feat: Record source performance counters in uproot.dask report Mar 1, 2024
@nsmith- nsmith- requested a review from jpivarski March 1, 2024 23:02
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I scanned over all of the changes. It looks like it does what you need, and I don't see any way that this could negatively impact any other parts of Uproot. So I'd say it's ready to merge!

In your example type, there were a lot of ?unknown fields. They must have been always None in the example that you ingested with ak.from_iter and checked the type of.

@nsmith-
Copy link
Member Author

nsmith- commented Mar 2, 2024

Yes, those are fields that are only set for failed files. I could force a failure to show the full type; it is a union of types as defined by _report_success and _report_failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants