Skip to content

Conversation

@lobis lobis marked this pull request as ready for review November 20, 2023 23:06
@lobis
Copy link
Contributor Author

lobis commented Nov 20, 2023

Feel free to merge this PR (I don't have write access to this repository).

@Moelf
Copy link
Collaborator

Moelf commented Nov 20, 2023

I low key want to wait for the PR that fixes this issue to be merged at the same time

@jpivarski
Copy link
Member

This only adds a file, so it seems to me that it would make more sense to merge it now.

The only reason I can see to hold back is if you think this (relatively large, 1.75 MB) file might change before the PR is done.

@lobis
Copy link
Contributor Author

lobis commented Nov 21, 2023

I low key want to wait for the PR that fixes this issue to be merged at the same time

This only adds a file, so it seems to me that it would make more sense to merge it now.

The only reason I can see to hold back is if you think this (relatively large, 1.75 MB) file might change before the PR is done.

I agree it makes sense to wait for the issue to be resolved, maybe this file ends up being useless.

With scikit-hep/uproot5@50b9ca4 I'll load the file from my fork until this is merged, so we can wait until the issue is resolved.

On a sidenote, I think it would be useful to be able to fetch files from a forked scikit-hep-testdata repository (the github url for the base repository is hardcoded). Not sure if there is an easy way to do this though.

@lobis
Copy link
Contributor Author

lobis commented Nov 24, 2023

I updated scikit-hep/uproot5#1036 to use another file already in the test data repository that is able to reproduce the same issue, so there is no need to add the file from this PR after all.

@lobis lobis closed this Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants