Require uproot to be version 3.0.0 or newer #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3.0.0 introduced a change in the public API for accessing fSumw2. This is needed to make sure that the code in pyhf/readxml.py works with uproot.
|
We somewhat discussed this in chat, but should this PR also introduce other requirements on the core dependencies? |
kratsg
approved these changes
Sep 20, 2018
|
LGTM |
|
Waiting on PR #268 and then this can go in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uprootv3.0.0introduced a change in the public API for accessing fSumw2. This is needed to make sure that the code inpyhf/readxml.pyworks withuprootthat were added in PR #276.Checklist Before Requesting Approver