fix: _chunked_kwargs not expanding kwargs if they're tuples even if t… #448
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he tuple isn't a valid mpl color
for more information, see https://pre-commit.ci
|
Before this fix, the following would not work (note the tuple of colors), now it does: hs = [hist.new.Reg(10,0,10).Weight().fill(np.random.normal(3+i, 1, 1000)) for i in range(3)] |
|
Ah, looks good. Thanks for the fix! |
rpsimeon34
pushed a commit
to rpsimeon34/mplhep
that referenced
this pull request
Oct 4, 2023
scikit-hep#448) * fix: _chunked_kwargs not expanding kwargs if they're tuples even if the tuple isn't a valid mpl color * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
jonas-eschle
pushed a commit
that referenced
this pull request
Apr 22, 2024
#448) * fix: _chunked_kwargs not expanding kwargs if they're tuples even if the tuple isn't a valid mpl color * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: _chunked_kwargs not expanding kwargs if they're tuples even if the tuple isn't a valid mpl color.
This issue confused me for a long time and is likely to come up if one uses the 'zip' builtin to zip up colours and histograms. Although this could be fixed by simply converting the tuple of colors returned by zip into a list, this is a better solution as it does not require users to read the source code to figure this out.