Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: raise minimum required matplotlib version to 3.5.0 #370

Merged
merged 2 commits into from
Oct 28, 2022

Conversation

alexander-held
Copy link
Member

The figure layout refactor introduced in cabinetry 0.5.0 requires matplotlib 3.5.0 or newer. Raise the minimum required version accordingly to prevent crashes with older versions.

resolves #369

* raise minimum required matplotlib version to 3.5.0

@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (207ec76) compared to base (564fef7).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #370   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines         2023      2023           
  Branches       320       320           
=========================================
  Hits          2023      2023           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alexander-held alexander-held merged commit 29065b5 into master Oct 28, 2022
@alexander-held alexander-held deleted the build/mpl-lower-bound-layout branch October 28, 2022 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

matplotlib versions older than 3.5 crash with cabinetry 0.5.0
1 participant