Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: channel splitting for multi-channel model predictions #312

Merged
merged 2 commits into from
Jan 13, 2022

Conversation

alexander-held
Copy link
Member

#303 introduced a bug in model_utils.prediction when used with multi-channel models. The split of yields into channels was happening at the wrong depth after this refactor. This update fixes the bug, and changes the corresponding test to catch such an issue.

* fixed channel splitting for multi-channel model predictions
* updated pre-commit

@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #312 (03b44cb) into master (9eb92b6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #312   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines         1873      1873           
  Branches       304       304           
=========================================
  Hits          1873      1873           
Impacted Files Coverage Δ
src/cabinetry/model_utils.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9eb92b6...03b44cb. Read the comment docs.

@alexander-held alexander-held merged commit bf3bab1 into master Jan 13, 2022
@alexander-held alexander-held deleted the fix/multi-channel-yield-split branch January 13, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant