Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make Samples property of modifiers optional #218

Merged
merged 9 commits into from
Apr 23, 2021

Conversation

alexander-held
Copy link
Member

@alexander-held alexander-held commented Apr 22, 2021

Systematics and NormFactors previously had a required Samples property to specify on which samples the modifier acts. This makes the property optional, and when not specified the modifier will act on all samples. Also unifies the functionality in the configuration module to avoid duplications due to the features required by #214, including harmonizing the Samples handling for smoothing.

partially addresses #214

breaking changes:

  • configuration.sample_affected_by_modifier renamed to configuration.sample_contains_modifier to harmonize naming with configuration.region_contains_sample and the upcoming configuration.region_contains_sample

@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #218 (b076f50) into master (d202b5b) will decrease coverage by 0.00%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #218      +/-   ##
==========================================
- Coverage   98.26%   98.25%   -0.01%     
==========================================
  Files          15       15              
  Lines        1730     1724       -6     
  Branches      270      268       -2     
==========================================
- Hits         1700     1694       -6     
  Misses         28       28              
  Partials        2        2              
Impacted Files Coverage Δ
src/cabinetry/workspace.py 84.21% <50.00%> (ø)
src/cabinetry/configuration.py 100.00% <100.00%> (ø)
src/cabinetry/template_postprocessor.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d202b5b...b076f50. Read the comment docs.

@alexander-held alexander-held changed the title feat: make Samples property optional for modifiers feat: make Samples property of modifiers optional Apr 22, 2021
@alexander-held alexander-held merged commit ef35f72 into master Apr 23, 2021
@alexander-held alexander-held deleted the feat/optional-sample-modifier branch April 23, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant