feat: make Samples property of modifiers optional #218
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Systematics
andNormFactors
previously had a requiredSamples
property to specify on which samples the modifier acts. This makes the property optional, and when not specified the modifier will act on all samples. Also unifies the functionality in theconfiguration
module to avoid duplications due to the features required by #214, including harmonizing theSamples
handling for smoothing.partially addresses #214
breaking changes:
configuration.sample_affected_by_modifier
renamed toconfiguration.sample_contains_modifier
to harmonize naming withconfiguration.region_contains_sample
and the upcomingconfiguration.region_contains_sample