Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct settings key to remove parts of the version in regex metadata plugin #887

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

philippjh
Copy link
Contributor

@philippjh philippjh commented Sep 3, 2024

Hello together.

I've been trying to use the remove settings key for the regex metadata plugin and noticed, that it has been non-functional for me. To me, it looks like the plugin acquires the wrong value from the settings dictionary (result instead of remove). This PR intends to change this to what I believe is correct.

@LecrisUT
Copy link
Collaborator

LecrisUT commented Sep 3, 2024

Looks correct. Funny thing is that this part is tested and passes somehow 😅

"result": "{major}.{minor}.{patch}dev{dev}",
"remove": r"dev0",
},
)
assert version == "1.2.3dev1" if dev else "1.2.3"

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.90%. Comparing base (26526bd) to head (e0fb2f6).
Report is 30 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #887   +/-   ##
=======================================
  Coverage   83.90%   83.90%           
=======================================
  Files          74       74           
  Lines        4387     4387           
=======================================
  Hits         3681     3681           
  Misses        706      706           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henryiii
Copy link
Collaborator

henryiii commented Sep 3, 2024

Good point, fixed the test. 🤦

@henryiii henryiii changed the title Use correct settings key to remove parts of the version in regex metadata plugin fix: use correct settings key to remove parts of the version in regex metadata plugin Sep 3, 2024
@henryiii henryiii merged commit 9f54443 into scikit-build:main Sep 3, 2024
61 checks passed
@philippjh philippjh deleted the fix-regex-remove branch September 3, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants