Improve behavior of return value outputs #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@gab1one Please test, and merge if satisfied. |
There may be other reasons affecting the decision to append the script's return value as an extra output. Let's be flexible.
Rather than relying on the return value being stored as an extra output, let's save the return value as its own reference. That way, in cases where the return value does _not_ get appended as an extra output, we still have a handle on it.
We want the return value to be an easy way to return a single, untyped (Object) output. This is quite useful for the "lazy" (I mean "elegant") script writer. But for those consuming scripts, it is annoying to always have to deal with this extra "result" output. As a compromise, let's only append the "result" output if: A) no other outputs were declared; and B) "result" was not declared as an input either.
Member
Author
|
@gab1one Any progress? I just rebased this over the latest master, so that it continues to merge cleanly. |
Member
Author
|
@gab1one Since I have still not heard back, I am going to merge this. I hope it does not break anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no explicit
@OUTPUTis given, the return value is appended.When an explicit
@OUTPUTis given, the return value is not appended.See knime-ip/knip-scripting/issues/78.