-
Notifications
You must be signed in to change notification settings - Fork 7
Correctly infer timezone from event begin time #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Timezones can come from the YAML file (`timezone: ...`), or from the event start time: `2025-07-15 17:00:00 +00:00` However it is specified, this timezone should be propagated to the RRULE. This PR is also a bit more strict, failing when the timezone specifier is unrecognized.
|
Needs tests still, but make timezoned events show up in our online calendar. Not sure whether mixed events (events specified in different timezones) will appear correctly. |
|
@bsipocz This should be good to go now. Tested with our online calendar, and all looks good. |
|
Thank you Stefan! I also push this back to the test PR in scientific-python/scientific-python.org#782 as I want to double check the generated outputs, not just the widget (as I recall we had issues with both). |
|
With this PR, the expectation is:
We could make UTC default, but that would be another change. |
|
I'm concerned about the SPEC Planning Meeting not shifting. It is specified in UTC ( I'm pretty sure I've tested this case, but let's confirm. |
|
Here's the ICS generated for the SP events; looks correct to me (using this PR), selecting UTC: |
|
For the floating SPEC meeting I used the format without the timezone info; which was fixed yesterday. So it's a no concern here. And we also cleared it up outside of github that the floating meetings is an expected behaviour; I consider it's a behavioural bug (I can't imagine a meeting for which we should allow it); but fixing that; I agree; falls beyond the scope for this PR. |
bsipocz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes here look good. Thanks!


Timezones can come from the YAML file (
timezone: ...), or from theevent start time:
2025-07-15 17:00:00 +00:00However it is specified, this timezone should be propagated to the RRULE.
This PR is also a bit more strict, failing when the timezone specifier is unrecognized.