Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix World.step reverting to fixed time step with 0 timeSinceLastCalled #337

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Grimeh
Copy link

@Grimeh Grimeh commented Oct 17, 2018

Calling World.step with a timeSinceLastCalled of 0 would cause it to revert
to the fixed time step behaviour. This was due to the default value of
timeSinceLastCalled being 0. This change checks for undefined, as opposed
to 0.

maxSubSteps still has a default value of 10.

See issue #334 for more details.

Calling World.step with a `timeSinceLastCalled` of 0 would cause it to revert
to the fixed time step behaviour. This was due to the default value of
`timeSinceLastCalled` being 0. This change checks for `undefined`, as opposed
to 0.

See issue schteppe#334 for more details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant