Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light background on dark text for subjects #85

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ewen-lbh
Copy link
Member

@ewen-lbh ewen-lbh commented May 11, 2020

Will resolve #84.

@ewen-lbh ewen-lbh changed the title light-background-on-dark-text-for-subjects Light background on dark text for subjects May 11, 2020
@codecov
Copy link

codecov bot commented May 11, 2020

Codecov Report

Merging #85 into master will increase coverage by 0.49%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #85      +/-   ##
=========================================
+ Coverage    4.28%   4.78%   +0.49%     
=========================================
  Files          60      60              
  Lines        2169    2175       +6     
  Branches      605     605              
=========================================
+ Hits           93     104      +11     
+ Misses       1720    1715       -5     
  Partials      356     356              
Impacted Files Coverage Δ
components/TheFooter.vue 0.00% <0.00%> (ø)
store/index.js 5.06% <0.00%> (-0.15%) ⬇️
components/CardSubject.vue 84.61% <0.00%> (+84.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c7797e...44e2f50. Read the comment docs.

@ewen-lbh
Copy link
Member Author

I'm going to redesign all modals in the future, but for now this should be an opt-in prop on <BadgeSubject>. Right now, the only place where subject badges (not dots) are visible is on the note editor, which is broken anyway.

On the current subject picker modal it looks horrendous

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Light background on dark text for subjects
1 participant