Moves all state to dedicated context class #47
Conversation
This commit moves all state that might change between serialization/deserialization runs into a dedicated class. This class is available to all classes which are concerned with the serialization and will it make super easy to propagate user specific settings to these classes.
|
|
||
| return null; | ||
| } | ||
|
|
||
| if ($isSerializing) { | ||
| foreach ($metadata->preSerializeMethods as $method) { | ||
| /** @var $method \ReflectionMethod */ |
There was a problem hiding this comment.
wouldn't it be better to put the right phpdoc on $metadata->preSerializeMethods so that it is infered by the IDE (\ReflectionMethod[]) ?
There was a problem hiding this comment.
I did this later on, see below.
|
i guess the |
|
@lsmith77, yeah I think you'll be able to simplify the API of the View class, and you would also not need to duplicate the API anymore. I've pushed a small update which splits the context into two different sub-classes, one for serialization and another for deserialization. We probably also need to make a similar change in the GraphNavigator. I also added a nice example how this new extension point can be used to invoke the Symfony Validator after the root object has been deserialized: <?php
$serializer->deserialize($data, 'json', 'class',
DeserializationContext::create()
->setAttribute('validation_groups', array('Group1', 'Group2'))); |
|
anyone motivated to work on a refactoring of FOSRestBundle for this? |
This commit moves all state that might change between serialization/deserialization runs into a dedicated class. This class is available to all classes which are concerned with the serialization and will make it super easy to propagate user specific settings to these classes.
In terms of BC, this affects mostly integration points like FOSRestBundle (cc @lsmith77) and will also affect some custom handlers of users. It will also require some of the pending PRs to be updated.
At this point, I'm interested in feedback whether I missed something that is broken by this change, or use-cases which this change makes impossible.