Fixing tests for bugfixed PHP versions #375
Conversation
|
+1 |
|
@urakozz I'm not a collaborator on this repo. So while I can still review this, I cannot merge it to fix the issue. |
|
@stof I see)) But maybe your conclusion might attract attention to this PR =) |
|
I had a quick look. It seems like this is again fixing the tests instead of fixing the code. If I missed something, please let me know. |
|
@schmittjoh Since DOMDocument bug [https://bugs.php.net/bug.php?id=67081] was fixed, |
| */ | ||
| private function getDomDocumentTypeEntitySubset(\DOMDocumentType $child, $data) | ||
| { | ||
| if(!$this->isBugFixedPhpVersion()){ |
There was a problem hiding this comment.
I would put the version check here directly
| */ | ||
| private function getDomDocumentTypeEntitySubset(\DOMDocumentType $child, $data) | ||
| { | ||
| if((PHP_VERSION_ID >= 50513) || (PHP_VERSION_ID >= 50429 && PHP_VERSION_ID < 50500)){ |
There was a problem hiding this comment.
aren't you missing a negation here ?
There was a problem hiding this comment.
Instead of checking for all the versions here, can we check for whether $child->internalSubset contains the data that we expect? That seems more robust to me.
Fixing tests for bugfixed PHP versions
Travis-CI tests fix (Final part of #292)