Better language detection and validation #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extended browser language detection by separating the language from the country.
|
Sounds good. Could you please add tests, and also check the CS of your patch? |
|
At the moment i haven't the time i try to squeeze this in sometime. |
|
This should really be merged... Its very broken otherwise. I've started to fix a couple of the other unit tests, however a number more need to be fixed up. |
|
+1 but patch looks not so good :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct me if i'm wrong but shouldn't the hl parameter in the cookie and request be validatet against the available locales ?
And i also extended the browser language detechtion by splitting the language from the country if both are set.