Specify service_container parameter explicitly when defining Router #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jms_i18n_routing.router service definition uses frameworks router.default service as a parent in it's definition. The parent relies on autowiring to inject Psr\Container\ContainerInterface as a first parameter. Autowiring of ContainerInterface has been deprecated since Symfony 5.1 and services using it need to define this parameter explicitly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jms_i18n_routing.routerservice definition uses frameworksrouter.defaultservice as a parent in it's definition. The parent relies on autowiring to injectPsr\Container\ContainerInterfaceas a first parameter.Autowiring of ContainerInterface has been deprecated since Symfony 5.1 and services using it need to define this parameter explicitly or Symfony triggers the following deprecation warning:
I've checked all existing Symfony versions and Container is always the first parameter, but there is a potential for a breaking change with new Symfony versions if they decide to switch it's position in the constructor definition (unlikely).
This PR fixes #249.