New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use session if not previously started #226

Open

EmmanuelVella wants to merge 1 commit into schmittjoh:2.0 from EmmanuelVella:session

EmmanuelVella commented Jul 19, 2018

Currently the DefaultLocaleResolver uses the session even when not already started, which make the responses uncacheable since symfony 3.4.

EmmanuelVella force-pushed the session branch 4 times, most recently from 53d3a13 to d95962c Compare

July 24, 2018 08:22


          Do not use session if not previously started

4deff6a

EmmanuelVella force-pushed the session branch from d95962c to 4deff6a Compare

July 24, 2018 13:10

Author

EmmanuelVella commented Mar 12, 2020

Still an issue ! If someone is ok to merge this, I will rebase it on 3.x branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet