[Router] Adapt code since Symfony 4 is now required #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deguif
force-pushed
the
symfony-4-adaptation
branch
2 times, most recently
from
b56b26a
to
003ee30
Compare
|
Hi @deguif thanks for the patch! However, as you said, this is a BC change (not sure how many people use a custom I18nRouter though) and I'd like not to merge it unless is solving some kind of bug. |
deguif
force-pushed
the
symfony-4-adaptation
branch
from
003ee30
to
ec692ae
Compare
deguif
force-pushed
the
symfony-4-adaptation
branch
from
ec692ae
to
d8c9661
Compare
|
I just updated the code to remove the BC change related to I18nLoader injection, this will remains as before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes compatibility with Symfony 2 in Router class.
I also update the code to be more Symfony 4.
Breaking change is that now the I18nLoader service is injected instead of the id.