Removing unused video_player dependency #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kawa89
reviewed
Feb 28, 2022
example/README.md
Outdated
| @@ -3,6 +3,4 @@ | |||
| | Platform | Example interface | Sample tweet | | |||
| |:--------:|:--------------------------------------------------------------------|:------------------------------------------------------------------------| | |||
| | Android |  |  | | |||
| | iOS |  |  | | |||
|
|
|||
| > Video/GIF Tweets don't work on iOS simulators ([video_player ios instructions](https://pub.dev/packages/video_player#ios)) | |||
There was a problem hiding this comment.
Is this sentence not true anymore:
Video/GIF Tweets don't work on iOS simulators
If it's still valid, we should leave it
There was a problem hiding this comment.
Reverted it
kawa89
reviewed
Apr 4, 2022
CHANGELOG.md
Outdated
| - Removing lock file from repository - adding it to gitignore | ||
| - Updating ios version for example project to 11 to support better player | ||
| - Regenerating example project with flutter create command | ||
| - Removing unused video_player dependency |
There was a problem hiding this comment.
I think we can divide the Changelog a bit more, to use ### Removed for Removing unused video_player dependency and the lock file.
kawa89
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.