Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweet with video doesn't show the video #95

Closed
jpcodr opened this issue Apr 1, 2022 · 9 comments
Closed

Tweet with video doesn't show the video #95

jpcodr opened this issue Apr 1, 2022 · 9 comments
Labels
bug Something isn't working

Comments

@jpcodr
Copy link

jpcodr commented Apr 1, 2022

Describe the bug
Hi

I'm using tweet_video.json from the example folder. The tweet renders fine but the video is not displayed even with a clean project. This occurs with both versions 3.0.1 and 4.0.0-dev-1 but the behavior is a little different.
3.0.1 After load video, CircularProgressIndicator is removed you can press play and other actions, the video is playing but the screen remains in black.

4.0.0-dev.1 Same as 3.0.1 but the CircularProgressIndicator is not removed.

To Reproduce
Steps to reproduce the behavior:

  1. Create a new project
  2. Install tweet_ui
  3. Use a tweet with video
  4. See error

Expected behavior
The video is displayed correctly

Screenshots
Simulator Screen Shot - iPhone 13 - 2022-04-01 at 15 41 50

Smartphone (please complete the following information):

  • Device: iPhone 13 iOS 15.2 (Simulator)
  • OS: MacOs
  • Version: 12.3.1
@jpcodr jpcodr added the bug Something isn't working label Apr 1, 2022
@wszeborowskimateusz
Copy link
Collaborator

wszeborowskimateusz commented Apr 2, 2022

Have you tried on real ios device @jpcodr? As written in the Readme

Video/GIF Tweets don't work on iOS simulators (video_player ios instructions)

Also did you follow the instructions for ios support for better_player - https://jhomlala.github.io/betterplayer/#/install

@jpcodr
Copy link
Author

jpcodr commented Apr 4, 2022

HI @wszeborowskimateusz

Have you tried on real ios device @jpcodr? As written in the Readme

Where is it written?

Also did you follow the instructions for ios support for better_player - https://jhomlala.github.io/betterplayer/#/install

Yes

@wszeborowskimateusz
Copy link
Collaborator

OK, as I see it is written in the README of example folder. Maybe this should be written in the main README? WDYT @kawa89 ?

@kawa89
Copy link
Collaborator

kawa89 commented Apr 4, 2022

@wszeborowskimateusz I Think it should be in the main readme :)

@wszeborowskimateusz
Copy link
Collaborator

OK, I added this comment in this PR - #84

@jpcodr
Copy link
Author

jpcodr commented Apr 4, 2022

@wszeborowskimateusz

I confirm that it works on emulator and android device as well as on iOS device. That notice should definitely be in the main Readme.

Also it's a bit weird that the videos are not displayed in the simulator. I'm using the video_player plugin to display other videos in my app and works well in the simulator

@jpcodr
Copy link
Author

jpcodr commented Apr 27, 2022

@kawa89 @wszeborowskimateusz

I think this issue can be closed.

Also, i have a question. I don't know where to do it cause is not an issue. Is there any way to autoplay the videos?

@wszeborowskimateusz
Copy link
Collaborator

As I see there is no such option currently. You can file a feature request so we can add it.

@jpcodr
Copy link
Author

jpcodr commented Apr 28, 2022

Thank you @wszeborowskimateusz.

I created the feature request #105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants