scx_rustland: get rid of --builtin-idle option #325
Merged
+7
−30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 23b0bb5 ("scx_rustland: dispatch interactive tasks on any CPU") allows only interactive tasks to be dispatched on any CPU, enabling them to quickly use the first idle CPU available. Non-interactive tasks, on the other hand, are kept on the same CPU as much as possible.
This change deprioritizes CPU-intensive tasks further, but it also helps to exploit cache locality, while latency-sensitive tasks are dispatched sooner, improving overall responsiveness, despite the potential migration cost.
Given this new logic, the built-idle option, which forces all tasks to be dispatched on the CPU assigned during select_cpu(), no longer offers significant benefits. It would merely reduce the responsiveness of interactive tasks.
Therefore, simply remove this option, allowing the scheduler to determine the target CPU(s) for all tasks based on their nature.
Fixes: 23b0bb5 ("scx_rustland: dispatch interactive tasks on any CPU")