Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed content view size to be correct #444

Closed
wants to merge 2 commits into from
Closed

Fixed content view size to be correct #444

wants to merge 2 commits into from

Conversation

itsol-ka
Copy link

@itsol-ka itsol-ka commented Mar 3, 2021

Content view size is incorrect when using autolayout for content view.
Fixed content view size to be correct.

maybe related #259

scenee
scenee requested changes Mar 4, 2021
View reviewed changes
Tests/SurfaceViewTests.swift Outdated
let contentView = UIView()
let titleLabel = UILabel()
contentView.addSubview(titleLabel)
contentView.translatesAutoresizingMaskIntoConstraints = false
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be titleLabel.translatesAutoresizingMaskIntoConstraints = false. And if it changes, then this test case is passed even if the priority is still .required - 1. So this test case is not a sufficient reason for the priority change.

The background where the priority was set to .required - 1(= 999) is #359. So we have to take care of its case.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing out the test mistake.
I will rethink

@Batvos
Copy link

Batvos commented Apr 28, 2021 •
edited
Loading

Hi,

This PR fixed my issue with content size when I use uicollectionview with animated snapshot inside content view.
@scenee Could you merge it or clarify what should be done to accept this PR.

@scenee
Copy link
Owner

scenee commented Apr 29, 2021 •
edited
Loading

@Batvos Is FloatingPanelController.contentMode of your panel static? I think we need these priority change according to the content mode.

@scenee scenee mentioned this pull request Nov 27, 2021
Merged
@scenee
Copy link
Owner

scenee commented Nov 27, 2021

Hi there,
I've finally acknowledged this priority issue to be resolved for the .static content mode in #515. So I've create #519.
I closed this PR but I really appreciate your PR to let me know this issue for the first time.

@scenee scenee closed this Nov 27, 2021
scenee added a commit that referenced this pull request Nov 29, 2021
@scenee
Change constraint priorities of the content view on the default conte…
6907836 
…nt mode (#519)

They were set to `.required - 1` is #359, which fixed #294. However #294
was an issue on `.fitToBounds` content mode. But because of #444 and #515,
if your panel’s content mode is `.static`, their priorities should be set to
`.required` on `.static` content mode.
@itsol-ka
Copy link
Author

Thank you for fixing the bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scenee scenee scenee requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@itsol-ka @Batvos @scenee