Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset the moveAnimator prop after a move animation #396

Merged
merged 2 commits into from
Oct 19, 2020
Merged

Reset the moveAnimator prop after a move animation #396

merged 2 commits into from
Oct 19, 2020

Conversation

scenee
Copy link
Owner

@scenee scenee commented Oct 17, 2020 •
edited
Loading

If moveAnimator isn't null, FloatingPanelPanGestureRecognizer.touchesBegan detects began state quickly so that it doesn’t allow to work a tap gesture or tap action in a panel.

Resolve #392

@scenee
Reset the moveAnimator prop after a move animation
dcac2e0 
If `moveAnimator` isn't null, `FloatingPanelPanGestureRecognizer.touchesBegan`
detects `began` state quickly so that it doesn’t allow to work a tap gesture or
tap action in a panel.

Resolve #392
@scenee scenee mentioned this pull request Oct 17, 2020
Closed
@scenee scenee merged commit 02d8d45 into master Oct 19, 2020
@scenee scenee deleted the fix-move-animation branch October 19, 2020 10:17
@scenee scenee mentioned this pull request Nov 7, 2020
Closed
@scenee scenee mentioned this pull request Dec 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Undefined behavior when controlling panel only by move(to: FloatingPanelState
1 participant
@scenee