Fix the panel behavior in a sheet modal #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 22, 2020
Merged
scenee
force-pushed
the
fix-modal-presentation
branch
from
0cbfedc to
a62c3a2
Compare
|
Hi SCENEE thank you for looking at this I will test today. |
|
Hello, @chriskilpin. I would be glad if you could give me your feedback 😄 |
|
Hi @scenee I have tested on my end and things are working as expected. Thanks again for sorting this out. |
|
@chriskilpin and @FlashTang, Thank you so much for your supports! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following pane behavior in a sheet modal.
This fixes this issue #274 (comment) (Thanks to @FlashTang), and also fixes #298 partially.
Limitation in Sheet modal
If a panel's content view controller has a scroll view, a sheet modal always moves when a panel is dragged. This is because a sheet modal automatically capture a scroll view gestures and the lib is not able to prevent it.