Fix show segue problem #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scenee
force-pushed
the
fix-show-segue-problem
branch
2 times, most recently
from
a184b59 to
514c3c9
Compare
|
Well, I'm thinking now. It might be better for FloatingPanelController to handle show(_:sender) to show a secondary floating panel for decoupling the need to display a view controller from the process of actually presenting a floating panel. |
scenee
force-pushed
the
fix-show-segue-problem
branch
3 times, most recently
from
5ab6d8a to
392700c
Compare
|
Now you can handle 'Show' segue to show a secondary floating panel. See "'Show' or 'Show Detail' Segues" note in README for detail. |
scenee
force-pushed
the
fix-show-segue-problem
branch
3 times, most recently
from
55f124b to
b654f86
Compare
…iewController:) And add a sample code to test show(_:sender:) in ContentVC. `FloatingPanelController.show(_:sender:)` can block 'Show' segue in a content view controller. 'Show' segue should not be handled by 'FloatingPanelController`. So I replace this method.
scenee
force-pushed
the
fix-show-segue-problem
branch
from
b654f86 to
0cf0f42
Compare
3 tasks
dscyrescotti
pushed a commit
to dscyrescotti/FloatingPanel
that referenced
this pull request
Jun 16, 2022
Fix show segue problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #20
FloatingPanelController.show(_:sender)is confusing. I don’t expect to work Show segues from a floating panel and I don't think it should work. So I'd like to deprecate the method on this PR, and replace it withFloatingPanelController.set(contentViewController:). The change is planning to be merged into v1.2.0.If you use "Show" or "Show Detail" segue from a floating panel, it will raise a fatal error."Show" or "Show Detail" segue from a content VC of a floating panel will be handled by a view controller managing a floating panel.
Finally,
FloatingPanelController.set(contentViewController:)might be updated toFloatingPanelController.set(contentViewController:animated:)to replace a content view with an animation.