Fix surface mask #190
Merged
Fix surface mask #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
scenee
commented
Apr 11, 2019
•
scenee
commented
- Fix masking a content view unexpectedly after v1.4.0.
- Also fix contentViewController is masked with a gray layer in iOS 10 and iOS 11 #109 probably because now a content view's border isn't changed.
- Move `contentView` into `backgroundView` to fix the mask - Also fix the mask problem on iOS 10-11. See for detail, #109.
scenee
force-pushed
the
fix-surface-mask
branch
from
bbf904b to
a8a35c4
Compare
scenee
force-pushed
the
fix-surface-mask
branch
from
a8a35c4 to
8e4b56f
Compare
Removing this setting will fix a warning emitted by Xcode to update project settings.
scenee
force-pushed
the
fix-surface-mask
branch
from
11a75ed to
5888104
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.