Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling jumps when tableView content is small #524

Closed
iharandreyev opened this issue Jan 11, 2022 · 5 comments
Closed

Scrolling jumps when tableView content is small #524

iharandreyev opened this issue Jan 11, 2022 · 5 comments

Comments

@iharandreyev
Copy link

iharandreyev commented Jan 11, 2022

Description

Table view content jumps when content is not large

Expected behavior

The scrolling continues properly when floating panel is expanded

Actual behavior

The scrolling jumps

Steps to reproduce

Open provided maps example. Go into setUpSearchView() function and replace 98 favorite items number with something small , for example 2.

How do you display panel(s)?

Add as child view controllers

How many panels do you display?

1

Environment

Library version

2.5.1

Installation method

CocoaPods

iOS version(s)

14.5 simulator

Xcode version

12.5.1

Simulator.Screen.Recording.-.iPhone.SE.2nd.generation.-.2022-01-11.at.19.12.56.mp4
@iharandreyev
Copy link
Author

Adding a large enough footer view to the table mitigates the issue. However, it is not a good enough solution since our table view base class already uses the footer, and tinkering with it will result in issues

@iharandreyev
Copy link
Author

iharandreyev commented Jan 11, 2022

For anyone having the same issue, I've mitigated it with bottom inset adjustment. May share the code upon request

@scenee
Copy link
Owner

scenee commented Jan 20, 2022

Thank you for your report. I acknowledged this issue. I will try to fix this later.

@mustafaozdemir
Copy link

For anyone having the same issue, I've mitigated it with bottom inset adjustment. May share the code upon request

Could you share your solution
Thanks

@scenee scenee mentioned this issue Apr 6, 2023
scenee added a commit that referenced this issue Apr 8, 2023
… view (#584)

UIScrollView would unexpectedly change its scroll offset after updating the bounces property when dealing with small scrollable content. This fixes issue #524, "Scrolling jumps when tableView content is small".
@scenee
Copy link
Owner

scenee commented Apr 8, 2023

Thank you for your patience. I've fixed this issue on the master branch now. It will be released on 2.6.2.

@scenee scenee closed this as completed Jun 3, 2023
scenee added a commit that referenced this issue Jun 24, 2023
448fc5c has a critical regression of scroll tracking, that the scroll content
can bounce after moving a panel, for example, pulling down it from full to half
state.

Through the reinvestigation of #524, I found this issue only occured on
fitToBounds mode(and a small content).

Therefore I fixed the issue by the more specific way.
scenee added a commit that referenced this issue Jun 26, 2023
Commit 448fc5c has a critical regression in scroll tracking that can cause the
scroll content to bounce after moving a panel, for example, pulling down it from
full to half state.

By re-investigating #524, I found that this problem only occurred with the
fitToBounds content mode(and a small scroll view content).

Therefore I fixed it in the more specific way.
scenee added a commit that referenced this issue Jul 1, 2023
Commit 448fc5c has a critical regression in scroll tracking that can cause the
scroll content to bounce after moving a panel, for example, pulling down it from
full to half state.

By re-investigating #524, I found that this problem only occurred with the
fitToBounds content mode(and a small scroll view content).

Therefore I fixed it in the more specific way.
scenee added a commit that referenced this issue Jul 1, 2023
…nt (#524)

This is the revised version of commit 448fc5c.

Commit 448fc5c has a critical regression in scroll tracking that can cause the
scroll content to bounce after moving a panel, for example, pulling down it from
full to half state.

By re-investigating #524, I found that this problem only occurred with the
`fitToBounds` content mode and a small scroll view content.

Therefore I fixed it in the more specific way.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants